Remove more OmicronZoneConfig
to BlueprintZoneConfig
conversions
#5584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #5583; see it for rationale.
We remove half of the remaining callers that want to convert
OmicronZoneConfig
intoBlueprintZoneConfig
:nexus-test-utils
's quasi-RSS: This now works in terms ofBlueprintZoneConfig
, and converts down toOmicronZoneConfig
when necessary. This is the kind of transformation we'd like to make in real RSS, too, although it will be more complex there.nexus-reconfigurator-execution
: replaced using therepresentative()
collection (which includes a collection from a live system, but no blueprint) with theexample()
system (which produces both a collection and a matching blueprint).The remaining users of this conversion direction are the most difficult, but at least we're down to three:
nexus-db-model
does this conversion to use some shared database serialization logic. This will necessarily change when we add to blueprints, since the serialization logic won't be shared anymore (or at least not as shared).nexus-test-utils
; I'll see when it becomes necessary.Even if the last two have to keep this conversion direction for now (which will become more complex as data is added), at least it's only two! That should be manageable even if the process gets a little messy.