[nexus] move inventory collection IDs to TypedUuid #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
changed the title
jgallagher
approved these changes
Apr 12, 2024
sunshowers
deleted the
sunshowers/spr/move-inventory-collection-ids-to-typeduuid
branch
jgallagher
added a commit
that referenced
this pull request
Apr 12, 2024
sunshowers
added a commit
that referenced
this pull request
Apr 15, 2024
I wanted to understand how internal DNS works wrt the reconfigurator, so I tried to port it over to using TypedUuid to basically get an overview via compile errors. Here's the result. I realized that we actually were overloading the `Host::Zone`'s ID to mean either the sled ID (for dendrite) or the zone ID (for the `Other` variant). I've addressed that in the PR by making the variant also carry the ID. (This was always an expected outcome of the transition to typed UUIDs -- if we really are storing more than one kind of UUID within a field, we should make that clear by specifying our own enum variants.) Probably depends on #5517 due to shared imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite mechanical in the end -- just updating types everywhere.