Restore instance tests to #5172 #5294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore instance tests added in #4691 so that they work with the latest updates in #5172. The tests now use the new `StorageManagerTestHarness` from #5172 instead of the since removed `FakeStorageManager`. Additionally, the dns server code from `sled-agent/src/fakes/nexus` is used rather than the reimplementation in #4691. This shrinks the amount of code added with these tests.
andrewjstone
commented
Mar 20, 2024
smklein
approved these changes
Mar 20, 2024
smklein
merged commit f129287
into
sled-agent-api-to-manage-phys-disks
19 of 21 checks passed
smklein
deleted the
ajs/sled-agent-api-to-manage-phys-disks/instance-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore instance tests added in #4691 so that they work with the latest updates in #5172. The tests now use the new
StorageManagerTestHarnessfrom #5172 instead of the since removedFakeStorageManager. Additionally, the dns server code fromsled-agent/src/fakes/nexusis used rather than the reimplementation in #4691. This shrinks the amount of code added with these tests.