Unquarantine clickhouse binary on mac #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
lgtm!
As mentioned in #oxide-control-plane, it's definitely quite weird that this (or homebrew for that matter) is hitting the quarantine bit. Generally only files downloaded via a web browser are supposed to trigger quarantining -- untarred files aren't supposed to. But figuring that out's for a future time, and there's nothing wrong with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5127 (I assume, because this problem came up immediately after that) macOS Gatekeeper is putting the
clickhousebinary in quarantine after download, which means we can't execute it unless we take it out of quarantine. This is apparently a new thing, as this doc about how to do that was only added Jan 9.Here I am doing it in the simplest way possible: if mac, then remove quarantine attr. If anyone has a better way, I'm all ears.