Make snapshot delete's SPACE_ACCOUNT idempotent #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SPACE_ACCOUNT node in the snapshot delete saga is not idempotent, and will fail to compensate for the forward action. This will lead to undercounting if the snapshot delete unwinds and the user deletes the snapshot again.
|
After thinking about this, if this PR is merged then we need to mimic what is done during the disk delete unwind, namely that we should transition the snapshot to I'd like to add more tests for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SPACE_ACCOUNT node in the snapshot delete saga is not idempotent, and will fail to compensate for the forward action. This will lead to undercounting if the snapshot delete unwinds and the user deletes the snapshot again.