Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progenitor to bc0bb4b #5071

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update progenitor to bc0bb4b #5071

merged 1 commit into from
Feb 15, 2024

Conversation

bnaecker
Copy link
Collaborator

No description provided.

@bnaecker bnaecker requested a review from ahl February 15, 2024 00:55
@bnaecker bnaecker force-pushed the update-progenitor branch 2 times, most recently from 00df4fa to bb1c829 Compare February 15, 2024 20:33
@ahl
Copy link
Contributor

ahl commented Feb 15, 2024

looks good; I'd love to see this either 1. happen automatically (@sunshowers ? @augustuswm ?) or 2. for us to switch to the crates.io version.

@bnaecker
Copy link
Collaborator Author

Yeah, that'd be nice. We're already ahead of the crates.io version, so we could switch to that on its next release there. Or include this in the configurations for one of the bots.

@augustuswm
Copy link
Contributor

I can set up some bot configuration if the goal is to track against a specific branch (i.e. main) for progenitor if that is needed. Do we usually rely on progenitor features that are not included in the current crates.io release?

@bnaecker
Copy link
Collaborator Author

I'm not specifically relying on new features, but the fact that this is a git dependency does often create trouble for me when making changes that span repositories. Propolis, Crucible, and Omicron are the usual culprit. It's also very possible I'm doing something silly when making those changes!

@sunshowers sunshowers disabled auto-merge February 15, 2024 21:48
@sunshowers
Copy link
Contributor

oh crap, accidentally hit the disable auto merge button, sorry!

@sunshowers sunshowers enabled auto-merge (squash) February 15, 2024 21:48
@sunshowers
Copy link
Contributor

Yeah I'd love it if we switched to the crates.io version. Renovate doesn't understand git dependencies at the moment—i was hoping to add that at some point but then other priorities happened.

@bnaecker
Copy link
Collaborator Author

@sunshowers Ok, that sounds good. I think we can do that after the next version bump on crates.io, since we're ahead of it right now.

@sunshowers sunshowers merged commit eda0550 into main Feb 15, 2024
21 checks passed
@sunshowers sunshowers deleted the update-progenitor branch February 15, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants