add route stage to saga dag, fix destination property #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few mistakes I made in the tunnel routing PR that moved the responsibility of static route management from Dendrite in to Maghemite. In Omicron this transition involved adding a new saga stage for adding routes on the switches through Maghemite. But I a) forgot to actually add that new stage to the saga's DAG and b) had a bug in translation between Omicron data structures and Maghemite data structures.
I've tested that we can now add new ports with static routes with this change in place, which we could not before - the new routes would not show up.