Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omdb sled-agent bootstore status #5041

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add omdb sled-agent bootstore status #5041

merged 4 commits into from
Feb 13, 2024

Conversation

andrewjstone
Copy link
Contributor

@andrewjstone andrewjstone commented Feb 10, 2024

I ended up creating an API type, BootstoreStatus, that is suitable for JSON / OpenAPI.

Fixes #4295 and #3722

I had to resort to using a string here, which feels somewhat icky. I could
convert the internal bootstore status type to an external type suitable
for schemars and json, although I also find this annoying.

Fixes #4295 and #3722
@andrewjstone andrewjstone marked this pull request as ready for review February 13, 2024 00:58
@andrewjstone
Copy link
Contributor Author

Output from running this on the testbed against the g0 sled-agent.

root@oxz_switch:~# omdb sled-agent --sled-agent-url http://[fd00:1122:3344:101::1]:12345 bootstore status
fsm ledger generation: 1
network config ledger generation: Some(1)
fsm state: initial_member
peers (found by ddmd):
    [fdb0:a840:2500:3::1]:12347
    [fdb0:a840:2500:5::1]:12347
    [fdb0:a840:2500:7::1]:12347
established connections:
     Pc { identifier: "g1", model: "i86pc" } : [fdb0:a840:2500:3::1]:12347
     Pc { identifier: "g2", model: "i86pc" } : [fdb0:a840:2500:5::1]:12347
     Pc { identifier: "g3", model: "i86pc" } : [fdb0:a840:2500:7::1]:12347
accepted connections:
    <none>
negotiating connections:
    <none>

Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I think your test failure is legit, but just an expectorate one

bootstore/src/schemes/v0/peer.rs Outdated Show resolved Hide resolved
@andrewjstone andrewjstone enabled auto-merge (squash) February 13, 2024 17:12
@andrewjstone andrewjstone merged commit 6c9c9b7 into main Feb 13, 2024
21 checks passed
@andrewjstone andrewjstone deleted the bootstore-omdb-hook branch February 13, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add omdb plugin for bootstore
2 participants