Remove thing-flinger #5038
Merged
Remove thing-flinger #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
reviewed
Feb 9, 2024
smf/mgs-sim/config.toml
Outdated
| @@ -16,7 +16,7 @@ request_body_max_bytes = 536870912 | |||
| [switch] | |||
There was a problem hiding this comment.
These SMF config changes don't seem related to thing-flinger -- are they?
There was a problem hiding this comment.
Oh jeez. This is what I get for pushing at 2 am. I must have done a git add . with the mods from the testbed. Thanks Sean!
smklein
reviewed
Feb 9, 2024
|
|
||
| # An optional data link from which we extract a MAC address. | ||
| # This is used as a unique identifier for the bootstrap address. | ||
| # | ||
| # If empty, this will be equivalent to the first result from: | ||
| # $ dladm show-phys -p -o LINK | ||
| # data_link = "igb0" | ||
| data_link = "vioif1" |
There was a problem hiding this comment.
Pretty sure this is causing the deployment job to fail
Thing-flinger was used to deploy multinode omicron clusters running on commodity hardware for early testing needs. This was primarily used for early experimentation with trust-quorum secret sharing and other preliminary multi-node experiments. It deployed via SSH and was never intended to be used forever. It was a stop-gap that nobody has used in a while now that we have real hardware with wicket and the a4x2 falcon testbed. Fixes #5034
andrewjstone
force-pushed
the
remove-thing-flinger
branch
from
843480e to
7672289
Compare
smklein
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thing-flinger was used to deploy multinode omicron clusters running on commodity hardware for early testing needs. This was primarily used for early experimentation with trust-quorum secret sharing and other preliminary multi-node experiments. It deployed via SSH and was never intended to be used forever. It was a stop-gap that nobody has used in a while now that we have real hardware with wicket and the a4x2 falcon testbed.
Fixes #5034