Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin libxmlsec1 harder #5019

Closed
wants to merge 1 commit into from
Closed

pin libxmlsec1 harder #5019

wants to merge 1 commit into from

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Feb 7, 2024

Attempts to fix https://github.com/oxidecomputer/omicron/actions/runs/7821186431/job/21337581868 --

==> Upgrading 1 dependent of upgraded formulae:
Disable this behaviour by setting HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
libxmlsec1 1.3.2 -> 1.3.3

This happens before brew pin can run.

@iliana iliana requested review from jgallagher and zephraph February 7, 2024 21:46
@iliana iliana enabled auto-merge (squash) February 7, 2024 22:02
zephraph
zephraph approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@zephraph zephraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does anything ever work? Thanks for the fix @iliana.

@iliana
Copy link
Contributor Author

iliana commented Feb 7, 2024

How does anything ever work?

this is my life

@iliana iliana disabled auto-merge February 7, 2024 22:50
@iliana iliana mentioned this pull request Feb 7, 2024
Merged
@iliana
Copy link
Contributor Author

iliana commented Feb 7, 2024

Let's land #5023 instead.

@iliana iliana closed this Feb 7, 2024
@iliana iliana mentioned this pull request Feb 7, 2024
Merged
iliana added a commit that referenced this pull request Feb 8, 2024
@iliana
patch samael crate to include njaremko/samael#41 (#5023)
bdf9a22 
Points cargo at
https://github.com/oxidecomputer/samael/tree/oxide/omicron, which has
njaremko/samael#41 merged in.

Fixes #4920, reverts #5007, supersedes #5019.
@iliana iliana deleted the iliana/it-keeps-happening-2 branch May 16, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-crespo david-crespo david-crespo approved these changes

@zephraph zephraph zephraph approved these changes

@jgallagher jgallagher Awaiting requested review from jgallagher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iliana @zephraph @david-crespo