[wicketd] replace snafu with thiserror #4950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently the only use of snafu in omicron (outside of transitive
deps), and I figure it is simple enough that we can replace it with thiserror,
reducing use of a direct dependency.
This was the first time I'd encountered snafu so I read a bit about it. As far
as I understand, the main benefit of snafu is that it pushes you heavily
towards an error-per-module pattern. However, thiserror does permit that
pattern as well, and in practice it is only a little more verbose than snafu to
do right (
map_err
vscontext
, thoughsnafu
introduces new types thataren't in the source code like
IoSnafu
andParseSnafu
).I'd love to get your take on it though @andrewjstone.