Update progenitor from v0.4.0 -> v0.5.0 #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
update-progenitor
branch
from
a0e7817 to
bdd4443
Compare
|
This would definitely be nice to get squared away, as things pulling in Omicron and Progenitor as deps need to manually downgrade the latter to 0.4.x in order to avoid compiler errors due to the change in types. |
|
I agree! I've got a WIP in Propolis for publishing the vCPU kstats which necessitated the update anyway. I've got a few more pieces to tidy up on those WIPs before I tackle this, but I will definitely get to it this afternoon. |
- Update OpenAPI documents. The new Progenitor now adds the "description" key if it was not previously there, and augments it with some details about the schema for documentation purposes. - Manually ignore the "description" key in the test for the simulated / real Crucbile pantry API match.
ahl
reviewed
Jan 25, 2024
|
meta note: we're still using the git dependency so the fact that it's 0.4.0 or 0.5.0 is less important than getting to a more recent commit from main... |
- Delegate to Progenitor error's Display impl - Simpler check for strings in test
ahl
approved these changes
Jan 25, 2024
|
Is there a reason we can't use the numbered versions on crates.io? I logged a ticket on this a few weeks back when I had a bit of breakage downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.