Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus] mark schema tests as heavy, increase timeout for one of them #4832

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Jan 17, 2024

On my Linux machine, when running the tests in test_all, I'm starting to see
integration_tests::schema::nexus_applies_update_on_boot
fail because of a 60s timeout waiting for nexus to start. The failure is caused
due to contention -- the logs just seem to indicate each schema version taking
5-15 seconds to apply.

To address this, do two things:

  1. Mark the tests as heavy so that they run with less contention.
  2. Increase the timeout for this specific test to 120s.

In the future, we may want to do something more clever like breaking this test
up into several smaller ones.

Error message:

thread 'integration_tests::schema::nexus_applies_update_on_boot' panicked at nexus/tests/integration_tests/schema.rs:484:5:
Nexus should have started

Logs: https://gist.github.com/sunshowers/39ee99badc5f75c2a3154ea602aa95aa

Created using spr 1.3.5
@sunshowers sunshowers added the Test Flake Tests that work. Wait, no. Actually yes. Hang on. Something is broken. label Jan 17, 2024
@sunshowers sunshowers enabled auto-merge (squash) January 17, 2024 23:48
@sunshowers sunshowers merged commit 622df81 into main Jan 18, 2024
20 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/nexus-mark-schema-tests-as-heavy-increase-timeout-for-one-of-them branch January 18, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Flake Tests that work. Wait, no. Actually yes. Hang on. Something is broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants