Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package] Use topological sorting from omicron-zone-package #4816

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[package] Use topological sorting from omicron-zone-package #4816

merged 1 commit into from
Jan 16, 2024

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jan 15, 2024

This functionality is now provided in omicron-zone-package, as of oxidecomputer/omicron-package#57

@smklein smklein changed the title Use topological sorting from omicron-zone-package [package] Use topological sorting from omicron-zone-package Jan 15, 2024
@smklein smklein requested a review from luqmana January 15, 2024 23:21
luqmana
luqmana approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@luqmana luqmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling that out. Great to see it being useful elsewhere too!

@smklein smklein merged commit 146aa5f into main Jan 16, 2024
21 of 22 checks passed
@smklein smklein deleted the topo-sort branch January 16, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luqmana luqmana luqmana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @luqmana