[nexus-test-utils] set 60s timeouts for each init step #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
Created using spr 1.3.5
sunshowers
commented
Jan 10, 2024
smklein
approved these changes
Jan 10, 2024
| @@ -604,18 +636,21 @@ impl<'a, N: NexusServer> ControlPlaneTestContextBuilder<'a, N> { | |||
| dns_config_client.dns_config_put(&dns_config).await.expect( | |||
| "Failed to send initial DNS records to internal DNS server", | |||
| ); | |||
| dns_config | |||
| self.dns_config = Some(dns_config); | |||
There was a problem hiding this comment.
This is just to avoid a move between setup steps, yeah?
There was a problem hiding this comment.
With this pattern, we no longer have a way to return a value that the next step can use. This is the easiest way to work around that (and follows the pattern the rest of the builder uses anyway).
I ran into something similar with the update-engine and came up with the design to use step handles that can be passed around, but only resolved once steps start executing. For example,
omicron/update-engine/examples/update-engine-basic/main.rs
Lines 308 to 310 in 45b6651
Created using spr 1.3.5
sunshowers
deleted the
sunshowers/spr/nexus-test-utils-set-60s-timeouts-for-each-init-step
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4779 we're tracking what appears to be a ClickHouse initialization failure
during Nexus startup. Set a timeout of 60s for each step in the initialization
process.
These steps should usually not take more than 5 seconds each, so 60s is a
really comfortable buffer.