Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] time out tests in test_all after a duration #4780

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[tests] time out tests in test_all after a duration #4780

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bab802
[𝘀𝗽𝗿] initial version
sunshowers Jan 8, 2024
bd5ac2b
restrict timeouts to CI
sunshowers Jan 8, 2024
4ba5a41
Rebase
sunshowers Jan 9, 2024
a690f63
Fix, whoops
sunshowers Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# The required version should be bumped up if we need new features, performance
# improvements or bugfixes that are present in newer versions of nextest.
nextest-version = { required = "0.9.59", recommended = "0.9.64" }
nextest-version = { required = "0.9.64", recommended = "0.9.64" }

experimental = ["setup-scripts"]

Expand All @@ -30,5 +30,11 @@ command = 'cargo run -p crdb-seed --profile test'
clickhouse-cluster = { max-threads = 1 }

[[profile.default.overrides]]
filter = 'package(oximeter-db) and test(replicated)'
filter = 'binary_id(oximeter-db::replicated)'
test-group = 'clickhouse-cluster'

[[profile.default.overrides]]
filter = 'binary_id(omicron-nexus::test_all)'
# As of 2023-01-08, the slowest test in test_all takes 196s on a Ryzen 7950X.
# 900s is a good upper limit that adds a comfortable buffer.
slow-timeout = { period = '60s', terminate-after = 15 }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great, but I've seen tests on my laptop that take up to 1000 seconds -- the saga 'test_action_failure_can_unwind' tests are particularly slow, and definitely need optimizing.

I'm not even sure I'd say this timeout is "wrong" - that test needs fixing - but figured I'd mention it regardless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that test isn't part of test_all.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not great, but I've seen tests on my laptop that take up to 1000 seconds -- the saga 'test_action_failure_can_unwind' tests are particularly slow, and definitely need optimizing.

I'm not even sure I'd say this timeout is "wrong" - that test needs fixing - but figured I'd mention it regardless

Loading