[test-utils] run clickhouse in its own cwd #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
smklein
approved these changes
Jan 5, 2024
Created using spr 1.3.5
Created using spr 1.3.5
Created using spr 1.3.5
sunshowers
deleted the
sunshowers/spr/test-utils-run-clickhouse-in-its-own-cwd
branch
|
Following up, it appears that this may have caused #4779. It's really strange, though -- still investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickHouse likes to dump a file called
preprocessed_configs/config.xmlin itscwd. By default the cwd is the source tree, so sometimes if a test fails this
file gets left behind.
Fix this by moving the cwd to
<temp_dir>/cwd.I also made a couple other changes in the PR:
Utf8TempDiretc, simplifying path handling code which alreadyassumed UTF-8 paths anyway.
<temp_dir>/datastore. Ifigured this would minimize possible collisions between the datastore and the
cwd.
Fixes #4080.
Fixes #4634.