Rename disks when un-deleting and faulting #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When un-deleting phantom disks and setting them to faulted, use a new name that includes the disk's UUID: this ensures that even if a user created another disk with the same name in the project, the phantom disk can still be un-deleted and faulted, and eventually cleaned up. Fixes oxidecomputer#4673
smklein
approved these changes
Dec 14, 2023
Comment on lines
+660
to
+663
| /// to faulted to ensure that it won't be used. Use the disk's UUID as part | ||
| /// of its new name to ensure that even if a user created another disk that | ||
| /// shadows this "phantom" disk the original can still be un-deleted and | ||
| /// faulted. |
There was a problem hiding this comment.
It might be worth calling out - no matter how silly - that like, technically the user could be using this name for another too. Seems unlikely though!
There was a problem hiding this comment.
You're not wrong! added something in 1ac073e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When un-deleting phantom disks and setting them to faulted, use a new name that includes the disk's UUID: this ensures that even if a user created another disk with the same name in the project, the phantom disk can still be un-deleted and faulted, and eventually cleaned up.
Fixes #4673