add --include-deleted switch to omdb db instances
#4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but seems like this would be a useful flag & behaviour for all/most |
Several `omdb db` commands directly query CRDB and need to decide whether to filter out soft-deleted objects from their queries. Make this configurable on the command line and default to hiding deleted objects. This markedly improves the UX of `omdb db instances`, which previously included all deleted instances by default. This doesn't apply in cases where it's important always to include or exclude soft-deleted objects, e.g. when trying to reason about the graph of references between regions, volumes, and snapshots in response to a `validate` subcommand. Also clean up a couple of callers of `check_limit` who weren't actually setting a LIMIT clause in their queries. (The check is harmless in this case but will print a spurious warning if the query returns exactly the right number of rows.) Tested by running `omdb db` commands on the dogfood rack.
gjcolombo
force-pushed
the
gjcolombo/omdb-ignore-deleted
branch
from
ae2582d to
3f3b7c6
Compare
Good call. Fixed in 3f3b7c6 by making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
omdb db instancesincludes all instances, including all deleted instances. Since deleted instances don't currently get garbage-collected, this adds a lot of visual clutter to the command output and more or less requires the use of the--fetch-limitswitch to ensure that the instance of interest actually appears in the command output.Assume that more often than not the instance of interest is one that hasn't yet been deleted, make OMDB default to filtering out soft-deleted instances, and add an
--include-deletedswitch to revert to the old behavior if it's desired.Tested on the dogfood rack, verifying in particular that if I wanted to find all instances matching a specific name pattern, including deleted instances required me to add
--fetch-limit 3750to get them all, whereas excluding them (by running the command with no special arguments) returned all the instances of interest with the default fetch limit.Fixes #4647.