[sled-agent] address EarlyNetworkConfig issues from 20231130 dogfood mupdate #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sunshowers
commented
Dec 6, 2023
•
sunshowers
commented
- Log deserialization as both v1 and v0 failing.
- If an error occurs with deserialization as both v1 and v0, then preferentially return the error produced by v1 rather than v0.
- Add tests for bootstore blobs from earlier versions. If more fields are added in the future, this test should catch any issues that occur.
Created using spr 1.3.5
Created using spr 1.3.5
rcgoodfellow
reviewed
Dec 7, 2023
| /// Test that previous and current versions of `EarlyNetworkConfig` blobs | ||
| /// deserialize correctly. | ||
| #[test] | ||
| fn early_network_blobs_deserialize() { |
There was a problem hiding this comment.
FWIW: for little parsers like this, I really like using nom.
There was a problem hiding this comment.
Ah definitely if it's a bit more complex than this. In this case I figured it was just splitting by comma.
sunshowers
deleted the
sunshowers/spr/sled-agent-address-earlynetworkconfig-issues-from-20231130-dogfood-mupdate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.