Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus] Bump query limit for uninitialized sleds #4626

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[nexus] Bump query limit for uninitialized sleds #4626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion nexus/src/app/rack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,17 @@ impl super::Nexus {
) -> ListResultVec<UninitializedSled> {
debug!(self.log, "Getting latest collection");
// Grab the SPs from the last collection
let limit = NonZeroU32::new(50).unwrap();
//
// We set a limit of 200 here to give us some breathing room when
// querying for cabooses and RoT pages, each of which is "4 per SP/RoT",
// which in a single fully populated rack works out to (32 sleds + 2
// switches + 1 psc) * 4 = 140.
//
// This feels bad and probably needs more thought; see
// https://github.com/oxidecomputer/omicron/issues/4621 where this limit
// being too low bit us, and it will link to a more general followup
// issue.
let limit = NonZeroU32::new(200).unwrap();
let collection = self
.db_datastore
.inventory_get_latest_collection(opctx, limit)
Expand Down
Loading