Add functions to catch timeseries schema changes #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4330 |
bnaecker
force-pushed
the
test-functions-for-timeseries-schema-changes
branch
3 times, most recently
from
01577b7 to
409aaf5
Compare
bnaecker
commented
Dec 5, 2023
bnaecker
commented
Dec 5, 2023
bnaecker
commented
Dec 5, 2023
bnaecker
commented
Dec 5, 2023
smklein
approved these changes
Dec 8, 2023
- Move schema types from the `oximeter-db` crate to `oximeter` proper - Add a `SchemaSet` for storing a unique set of timeseries schema, and comparing against a set deserialized from file. This works like expectorate, with a few tweaks, and allows developers to catch any changes. If we want to relax this to catching _compatible_ changes, for some definition of that, we can do that pretty easily.
bnaecker
force-pushed
the
test-functions-for-timeseries-schema-changes
branch
from
409aaf5 to
06d4393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oximeter-dbcrate tooximeterproperSchemaSetfor storing a unique set of timeseries schema, and comparing against a set deserialized from file. This works like expectorate, with a few tweaks, and allows developers to catch any changes. If we want to relax this to catching compatible changes, for some definition of that, we can do that pretty easily.