[update-engine] fix GroupDisplayStats to avoid integer underflow #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
sunshowers
commented
Nov 27, 2023
| @@ -236,18 +236,9 @@ impl GroupDisplayStats { | |||
| } | |||
|
|
|||
| fn apply_result(&mut self, result: AddEventReportResult) { | |||
| // Process result.after first to avoid integer underflow. | |||
There was a problem hiding this comment.
This wasn't really good enough to avoid integer underflow 😅, so I decided to just check for equality and then do the more obvious thing of applying before before after.
Created using spr 1.3.5
Created using spr 1.3.5
Created using spr 1.3.5
Created using spr 1.3.5
Created using spr 1.3.5
sunshowers
deleted the
sunshowers/spr/update-engine-fix-groupdisplaystats-to-avoid-integer-underflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen if an empty
EventReportis passed in -- in that case we'dtransition to
Runningbut returnNotStarted.Fix this by not transitioning
self.kindtoRunningif we're going to returnNotStarted. This does bloat up the code a little but I think is cleareroverall.
Thanks to @jgallagher for all the help debugging this!
Also clean up some related logic and add tests.
Fixes #4507.