[omicron-dev] increase test timeout to 30 seconds #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
davepacheco
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
It looks like this timeout only covers the period between when we send SIGINT to omicron-dev db-run and when wait(2) (or some other wait syscall) returns an exit status. 15 seconds seems pretty long to wait for that? I don't think there's much harm in bumping this up -- I'm just worried something deeper is wrong.
|
Yeah, |
sunshowers
deleted the
sunshowers/spr/omicron-dev-increase-test-timeout-to-30-seconds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine (Ryzen 7950X) I saw that under load (32 tests running at the same
time), the timeout would quite reliably be hit likely because cockroach was
starved. Increasing it seems pretty harmless.