Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factor out a common port settings saga function missed in #4528 #4549

Merged
merged 1 commit into from
Nov 22, 2023
Merged

factor out a common port settings saga function missed in #4528 #4549

merged 1 commit into from
Nov 22, 2023

Conversation

rcgoodfellow
Copy link
Contributor

@rcgoodfellow rcgoodfellow commented Nov 22, 2023 •
edited
Loading

Tested things e2e this time in the a4x2 testbed topology.

jmpesp
jmpesp approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@jmpesp jmpesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Did you try un-ignoring test_port_settings_basic_crud?

@rcgoodfellow
Copy link
Contributor Author

Did you try un-ignoring test_port_settings_basic_crud?

I did, however, there are quite a few blockers there that I think need broader discussion regarding the overall approach to testing.

@rcgoodfellow rcgoodfellow merged commit 36f6abe into main Nov 22, 2023
20 checks passed
@rcgoodfellow rcgoodfellow deleted the 4509-attempt-2 branch November 22, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmpesp jmpesp jmpesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code reuse between switch port settings apply/clear sagas results in serialization error
2 participants
@rcgoodfellow @jmpesp