Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus] Add HostPhase1Updater #4548

Merged
merged 6 commits into from
Nov 30, 2023
Merged

[nexus] Add HostPhase1Updater #4548

merged 6 commits into from
Nov 30, 2023

Conversation

jgallagher
Copy link
Contributor

Continues the work from #4427 and #4502 adding types to Nexus that can deliver updates to components managed by the SP, and contains a similar amount of duplication from those two. Non-duplication changes are mostly refactoring:

  • Removed component-specific error types in favor of SpComponentUpdateError
  • Extracted the "start the update and poll MGS until it's done" logic into a new common_sp_update module

The test_host_phase1_updater_delivers_progress is subtly different from the RoT/SP versions of the same test, but not in a way that's particularly interesting (see the "Unlike the SP and RoT cases" comment for details).

Copy link
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the commonization here!

@jgallagher jgallagher merged commit 9023e15 into main Nov 30, 2023
20 checks passed
@jgallagher jgallagher deleted the john/host-phase1-updater branch November 30, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants