Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nexus-db-model] separate out SledUpdate from Sled #4533

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Nov 20, 2023

Sled consists of several columns that aren't controlled by sled-agent, and we
end up in this weird place where we have Sled instances that don't reflect
reality. I'm working on adding a provision_state column which is controlled
by the operator, and again for which sled-agent doesn't know.

Clean this up by defining a new struct, SledUpdate, which only contains the
columns sled-agent knows about. The other columns get defaults when
into_insertable is called.

Created using spr 1.3.5
@sunshowers sunshowers enabled auto-merge (squash) November 20, 2023 23:57
@sunshowers sunshowers merged commit e3e99ee into main Nov 21, 2023
19 of 20 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/nexus-db-model-separate-out-sledupdate-from-sled branch November 21, 2023 01:01
@sunshowers sunshowers mentioned this pull request Nov 21, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants