Improve wtmp record mangling. #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citrus-it
force-pushed
the
andy/ntp
branch
3 times, most recently
from
f92095f to
72054fe
Compare
citrus-it
force-pushed
the
andy/ntp
branch
2 times, most recently
from
1658b3a to
6851663
Compare
This fixes two problems with the current wtmp/utmp record mangling. First it is not idempotent, the system's notion of boot time is set to the current time of day whenever sled agent confirms that time is synchronised. Secondly, this is only approximate even for the first sled agent start, but it's plain wrong if sled agent restarts later. In conjunction with changes to stlouis, the `tmpx` utility is now able to process all zones itself, and uses the true system boot time for each zone when updating records. Fixes: #3514
jgallagher
approved these changes
Dec 4, 2023
| let mut command = std::process::Command::new(PFEXEC); | ||
| let cmd = command.args(&["/usr/platform/oxide/bin/tmpx", "-Z"]); | ||
| if let Err(e) = execute(cmd) { | ||
| warn!(self.inner.log, "Updating [wu]tmpx databases failed: {}", e); |
There was a problem hiding this comment.
We lost the info! log if this succeeds (although maybe it's less interesting to log "we successfully told tmpx to do its thing" than "we told tmpx to modify a specific file"?). I have no strong feeling either way but just wanted to confirm this is intentional.
There was a problem hiding this comment.
Yes, I had the same thought. The new tmpx is fire and forget, it will traverse all zones and idempotently fix up boot times, producing an error if anything goes wrong. I didn't think it was valuable to keep the success line (but I also have no strong feeling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems with the current wtmp/utmp record mangling. First it is not idempotent, the system's notion of boot time is set to the current time of day whenever sled agent confirms that time is synchronised. Secondly, this is only approximate even for the first sled agent start, but it's plain wrong if sled agent restarts later.
In conjunction with changes to stlouis, the
tmpxutility is now able to process all zones itself, and uses the true system boot time for each zone when updating records.Fixes: #3514