Remove a bunch of unused dependencies #4482
Conversation
| openssl-sys.workspace = true | ||
| openssl-probe.workspace = true |
There was a problem hiding this comment.
@jmpesp other than "tests pass" is there a way confirm this doesn't break anything? I see these are transitive deps of samael, but Nexus doesn't appear to depend on them directly.
There was a problem hiding this comment.
The samael / SAML tests are pretty extensive - I'd be more worried about incompatible openssl versions (or libxmlsec1, like here), something that I think we test by deploying to a helios machine during CI. I don't think there's anything an actual end-to-end SAML login would exercise over the unit tests though.
There was a problem hiding this comment.
Gotcha, I'll trust those end-to-end tests then!
|
The |
| openssl-sys.workspace = true | ||
| openssl-probe.workspace = true |
There was a problem hiding this comment.
The samael / SAML tests are pretty extensive - I'd be more worried about incompatible openssl versions (or libxmlsec1, like here), something that I think we test by deploying to a helios machine during CI. I don't think there's anything an actual end-to-end SAML login would exercise over the unit tests though.
I used
cargo macheteto find quite a few of these (https://github.com/bnjbvr/cargo-machete) .Notably this incurs a significant amount of false positives for the
client/crates using progenitor. I think this is because progenitor provides a macro, and simply expects clients to have the necessary dependencies on the crates being used (including:chrono,futures,regress,serde, etc).