Update Rust crate tough to 0.15 #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![oxide-renovate[bot]](https://avatars.githubusercontent.com/u/54040662?s=60&v=4){kind=small}
oxide-renovate
bot
added
the
dependencies
oxide-renovate
bot
force-pushed
the
renovate/tough-0.x
branch
2 times, most recently
from
c7b57cb to
96d749c
Compare
oxide-renovate
bot
force-pushed
the
renovate/tough-0.x
branch
from
96d749c to
768dff6
Compare
oxide-renovate
bot
changed the title
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
|
Ah crap, some failures that I need to address. |
iliana
reviewed
Nov 18, 2023
jgallagher
reviewed
Nov 20, 2023
| .map_err(RepositoryError::LoadRepository)?; | ||
|
|
||
| let artifacts = repository | ||
| .read_artifacts() | ||
| .await | ||
| .map_err(RepositoryError::ReadArtifactsDocument)?; | ||
|
|
||
| // Create another temporary directory where we'll "permanently" (as long |
There was a problem hiding this comment.
UpdatePlanBuilder::new() uses camino_tempfile to create a temporary directory - should we spawn_blocking it? (Feels like maybe "technically yes since it's I/O, but practically probably doesn't matter"?)
There was a problem hiding this comment.
Ehhhh I really don't think it matters to be honest. This isn't an operation that takes a long time.
jgallagher
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.14->0.15Release Notes
awslabs/tough (tough)
v0.15.0Compare Source
Changes
Configuration
📅 Schedule: Branch creation - "after 8pm,before 6am" in timezone America/Los_Angeles, Automerge - "after 8pm,before 6am" in timezone America/Los_Angeles.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.