Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ClickHouse replicated cluster option for simulated omicron #4422

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

karencfv
Copy link
Contributor

@karencfv karencfv commented Nov 3, 2023

New --replicated flag for the omicron-dev ch-run command. This will allow us to spin up a ClickHouse replicated cluster containing 2 replicas and 3 keepers.

$ cargo run --bin omicron-dev -- ch-run --replicated
    Finished dev [unoptimized + debuginfo] target(s) in 0.31s
     Running `target/debug/omicron-dev ch-run --replicated`
omicron-dev: running ClickHouse cluster with configuration files:
 replicas: /home/{user}/src/omicron/oximeter/db/src/configs/replica_config.xml
 keepers: /home/{user}/src/omicron/oximeter/db/src/configs/keeper_config.xml
omicron-dev: ClickHouse cluster is running with PIDs: 1113482, 1113681, 1113387, 1113451, 1113419
omicron-dev: ClickHouse HTTP servers listening on ports: 8123, 8124
omicron-dev: using /tmp/.tmpFH6v8h and /tmp/.tmpkUjDji for ClickHouse data storage

Related: #4148

dev-tools/omicron-dev/src/bin/omicron-dev.rs Outdated Show resolved Hide resolved
dev-tools/omicron-dev/src/bin/omicron-dev.rs Outdated Show resolved Hide resolved
dev-tools/omicron-dev/src/bin/omicron-dev.rs Outdated Show resolved Hide resolved
oximeter/db/src/client.rs Show resolved Hide resolved
oximeter/db/src/client.rs Show resolved Hide resolved
test-utils/src/dev/clickhouse.rs Outdated Show resolved Hide resolved
@karencfv
Copy link
Contributor Author

karencfv commented Nov 7, 2023

Thanks for the review @bnaecker! I think I've addressed all your comments :)

@karencfv karencfv requested a review from bnaecker November 7, 2023 00:08
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@karencfv karencfv merged commit bd05e19 into oxidecomputer:main Nov 7, 2023
15 checks passed
@karencfv karencfv deleted the muti-node-ch-simulated branch November 7, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants