Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omdb could care less about the current database version #4371

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

davepacheco
Copy link
Collaborator

omdb has a cheesy test to check that its output doesn't change accidentally. It currently captures the current database schema version. We should redact this the way we do timestamps, uuids, etc. so that people don't have to update this test when they bump the database version.

@davepacheco davepacheco requested a review from leftwo October 26, 2023 22:54
Copy link
Contributor

@leftwo leftwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, Thanks for this.

@davepacheco davepacheco merged commit dd535ea into main Oct 26, 2023
19 of 20 checks passed
@davepacheco davepacheco deleted the dap/omdb-db-version branch October 26, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants