Remove timeseries schema from cache on insertion failure #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
cache-invalidation-ugh
branch
from
a04735d to
351118a
Compare
david-crespo
approved these changes
Oct 25, 2023
- Fixes #4335 - Factors out internals of `oximeter_db::Client::insert_samples()` to aid testing, and add regression - Remove new timeseries schema from the internal cache, if we fail to insert them into the schema table.
bnaecker
force-pushed
the
cache-invalidation-ugh
branch
from
7699c25 to
66c8eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oximetercan have schema in its cache that are not in the database #4335oximeter_db::Client::insert_samples()to aid testing, and add regression