Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port settings fixes #4343

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Port settings fixes #4343

merged 5 commits into from
Oct 25, 2023

Conversation

rcgoodfellow
Copy link
Contributor

@rcgoodfellow rcgoodfellow commented Oct 25, 2023 •
edited
Loading

Depends on

  • oxidecomputer/dendrite#664

@rcgoodfellow rcgoodfellow marked this pull request as ready for review October 25, 2023 06:00
Nieuwejaar
Nieuwejaar approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Nieuwejaar Nieuwejaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was literally about to send you a review with about half of this stuff in it already.

@rcgoodfellow rcgoodfellow enabled auto-merge (squash) October 25, 2023 18:08
@rcgoodfellow rcgoodfellow merged commit 159000a into main Oct 25, 2023
19 of 20 checks passed
@rcgoodfellow rcgoodfellow deleted the port-settings-fixes branch October 25, 2023 19:19
This was referenced Oct 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nieuwejaar Nieuwejaar Nieuwejaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rcgoodfellow @Nieuwejaar