[wicketd] Fall back to old behavior if SP is too old to support reading RoT CMPA/CFPA #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
reviewed
Oct 24, 2023
| "err" => %DisplayErrorChain::new(&err), | ||
| ); | ||
| } | ||
| Err(err) => { |
There was a problem hiding this comment.
Add a comment here that this covers communication errors, etc?
mkeeter
reviewed
Oct 24, 2023
| Ok(()) => { | ||
| })?) | ||
| } | ||
| // TODO is there a better way to check the _specific_ error response |
There was a problem hiding this comment.
I think this is fine; it's no worse than before!
mkeeter
reviewed
Oct 24, 2023
| break; | ||
| artifact_to_apply = Some(available_artifacts[0].clone()); | ||
| None | ||
| } else { |
There was a problem hiding this comment.
Add some logging here, since it's a weird corner case
mkeeter
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit this on rack3 but did not hit it on dogfood due to more frequent updates to dogfood's SP/RoT. Prior to this PR, wicketd expected to be able to ask an SP for its RoT's CMPA/CFPA pages, but if a rack is jumping from the 1.0.2 release to current master, its SPs are too old to understand that message. With this change, we will fall back to wicketd's previous behavior of requiring exactly 1 RoT archive if we fail to fetch the CMPA from the target component.