Refactor InstalledZone::install to use a builder pattern, per TODO. #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citrus-it
reviewed
Oct 24, 2023
lifning
force-pushed
the
sled-agent-zone-installation-builder
branch
3 times, most recently
from
0d02bce to
c76fcdb
Compare
lifning
force-pushed
the
sled-agent-zone-installation-builder
branch
3 times, most recently
from
e844555 to
739fcbd
Compare
lifning
force-pushed
the
sled-agent-zone-installation-builder
branch
from
739fcbd to
0c41f95
Compare
Additionally, make a builder-factory with an option to create fake builders, in service of refactoring some things to enable some unit tests being written.
lifning
force-pushed
the
sled-agent-zone-installation-builder
branch
from
0c41f95 to
f686829
Compare
citrus-it
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, make a builder-factory with an option to create fake builders, in service of refactoring some things to enable some unit tests being written.