Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nexus] Improve logging for schema changes #4309

Merged
merged 2 commits into from
Oct 21, 2023
Merged

[nexus] Improve logging for schema changes #4309

merged 2 commits into from
Oct 21, 2023

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Oct 20, 2023

Improves visibility of logging, indicating:

  • What version are we upgrading into, throughout the process
  • Logging the names of SQL files used for upgrade, as they occur

david-crespo
david-crespo approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you also ran into this so I don't have to figure it out!

@smklein smklein enabled auto-merge (squash) October 20, 2023 19:10
@smklein smklein merged commit 132efac into main Oct 21, 2023
20 of 21 checks passed
@smklein smklein deleted the schema-test-logging branch October 21, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-crespo david-crespo david-crespo approved these changes

@internet-diglett internet-diglett Awaiting requested review from internet-diglett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @david-crespo