Limit size of the search range for VNIs when creating VPCs #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
limit-vni-search-range
branch
from
51c899e to
fe94f96
Compare
|
Hmm looks like this hit the NTP test flake John noted earlier today. I’ll try the check again, but let me know if you’ve any suggestions in the meantime @smklein |
bnaecker
force-pushed
the
limit-vni-search-range
branch
from
c874626 to
2743c26
Compare
- Fixes #4283. - Adds a relatively small limit to the `NextItem` query used for finding a free VNI during VPC creation. This limits the memory consumption to something very reasonable, but is big enough that we should be extremely unlikely to find _no_ available VNIs in the range. - Add an application-level retry loop when inserting _customer_ VPCs, which catches the unlikely event that there really are no VNIs available, and retries a few times. - Adds tests for the computation of the limited search range. - Adds tests for the actual exhaustion-detection and retry behavior. Review feedback - Add const-assert that VNI search range is valid - Rename `Vpc::with_random_vni()` Search entire VNI range in chunks - Remove `IncompleteVpc::with_random_vni()` - Add iterator to search ranges of VNIs sequentially, yielding all range starts in the valid guest VNI range from a random starting VNI. - Instead of a limited retry loop when creating VPCs, search until the iterator is exhausted and we've searched the whole range. Throw in some DTrace probes fmt
bnaecker
force-pushed
the
limit-vni-search-range
branch
from
2743c26 to
25904f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextItemquery used for finding a free VNI during VPC creation. This limits the memory consumption to something very reasonable, but is big enough that we should be extremely unlikely to find no available VNIs in the range.