Code

IP pools data model and API rework#4261

Code

Merged

david-crespo merged 76 commits intomainoxidecomputer/omicron:mainfrom ip-pools-reworkoxidecomputer/omicron:ip-pools-reworkCopy head branch name to clipboardJan 5, 2024

+2,633-1,120

Commits

Commits on Oct 10, 2023

• migrations and diesel schema for ip_pool_resource join table

  david-crespo

  committed
  580594e

Commits on Oct 11, 2023

• add pools at rack setup time in the new way, update fetch_default_for

  david-crespo

  committed
  3065a61

• update service pool lookup logic

  david-crespo

  committed
  f3809b5

• delete silo_id and is_default from ip_pool model, test still passes

  david-crespo

  committed
  6404e27

• rip out silo_id and is_default on ip_pools in db

  david-crespo

  committed
  94d0ebf

• let's add an endpoint!

  david-crespo

  committed
  1de49fc

• use joinable to make our joins more cute

  david-crespo

  committed
  7259531

• get all ip_pools integration tests passing

  david-crespo

  committed
  4c8c5ea

• instance ephemeral IP test passes

  david-crespo

  committed
  5386043

Commits on Oct 12, 2023

• shuffle migration files in anticipation of merging main

  david-crespo

  committed
  a1eb6e4

Commits on Oct 18, 2023

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  9b4edaa

• unauthorized test

  david-crespo

  committed
  49c9927

• test for pagination logic

  david-crespo

  committed
  9c8d2d5

• exclude service pool from list and block delete/update/modification

  david-crespo

  committed
  ff3a4e2

• fix the tests!

  david-crespo

  committed
  db29bd3

Commits on Oct 19, 2023

• get conflict/update logic right around is_default

  david-crespo

  committed
  9cbc423

Commits on Oct 20, 2023

• add dissociate endpoint as DELETE /associate

  david-crespo

  committed
  ee5549c

• rename endpoints and params to match convention better

  david-crespo

  committed
  0ab0cfc

• change API to allow associating silo by name. it's beautiful

  david-crespo

  committed
  2b4f326

Commits on Oct 23, 2023

• move migration up a number before merging main

  david-crespo

  committed
  e2b7600

Commits on Oct 24, 2023

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  acda55a

Commits on Oct 25, 2023

• get silo ID so we can test association by name or id

  david-crespo

  committed
  80a4d22

• pluralize /associations for restiness, prep for list endpoint

  david-crespo

  committed
  9c101ac

• endpoint to list associations for IP pool

  david-crespo

  committed
  32b2f75

Commits on Nov 7, 2023

• don't allow creating IP with not-associated pool, orphan pool test

  david-crespo

  committed
  9519ed1

• note that we are relying on DB enum order for most specific, flip order

  david-crespo

  committed
  d7a0bdb

• fix tests broken by lack of ip association by default

  david-crespo

  committed
  e79b862

• first pass at checking for allocated IPs in associated pool before delete

  david-crespo

  committed
  c60ea2a

Commits on Nov 8, 2023

• move check for outstanding IPs into its own function

  david-crespo

  committed
  fa9317a

• correct logic for looking up outstanding IPs

  david-crespo

  committed
  2345f35

Commits on Nov 10, 2023

• fix dissociate query params type serialization

  david-crespo

  committed
  3226866

• these migrations go to 11. avoid conflict

  david-crespo

  committed
  1dd01c1

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  e8d1205

• git chose to delete something important

  david-crespo

  committed
  a47a9a3

Commits on Dec 4, 2023

• move migration to 19

  david-crespo

  committed
  6ea14ad

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  63e340c

• not sure how that became wrong again but whatever

  david-crespo

  committed
  b871acf

Commits on Dec 5, 2023

• IP pools can't be fleet-wide (#4616)

  Show description for 2094a8b
  

  david-crespo

  and

  zephraph

  authored
  2094a8b

• integration_tests::ip_pools all pass

  david-crespo

  committed
  9da8783

Commits on Dec 6, 2023

• make instance integration tests pass

  david-crespo

  committed
  a678c83

• fix nexus-db-queries tests

  david-crespo

  committed
  31b476f

• add make_default endpoint and give it one lil test

  david-crespo

  committed
  6a55e89

• passify a million angry integration tests

  david-crespo

  committed
  1b71818

• clean up mess of ip pool test helpers. now pristine-ish

  david-crespo

  committed
  75c0290

Commits on Dec 7, 2023

• update migrations for a world without fleet IP pools

  david-crespo

  committed
  7ff15b9

• ip_pool_make_default -> ip_pool_silo_update, much better tests

  david-crespo

  committed
  85922cd

• unauthorized tests pass. it's a miracle

  david-crespo

  committed
  7194ee2

Commits on Dec 8, 2023

• I think... all the tests pass

  david-crespo

  committed
  f9ed857

Commits on Dec 11, 2023

• test pool-silo unlink when there are/aren't IPs outstanding

  david-crespo

  committed
  d1e9b0a

• move schema version to v20

  david-crespo

  committed
  39a4a48

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  00f86a0

Commits on Dec 12, 2023

• fix issues introduced by main merge (still some tweaks required)

  david-crespo

  committed
  d74ccd4

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  ee12c4e

• ensure silo is linked to IP pool before allowing floating IP allocation

  david-crespo

  committed
  70724cb

• ensure no outstanding floating IPs before unlinking silo

  david-crespo

  committed
  69a482a

Commits on Dec 13, 2023

• verify there are no linked silos before deleting pool

  david-crespo

  committed
  7c0ba9d

• always use fully qualified name for SQL enum

  david-crespo

  committed
  5db1f09

• set up IP pool properly for e2e test

  david-crespo

  committed
  bbcd731

• move migration one more number up to 21

  david-crespo

  committed
  c761559

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  dcd76b3

• update quotas test for new ip pools helpers

  david-crespo

  committed
  6b2ffbc

• don't 500 when there is no default IP pool! be cool instead

  david-crespo

  committed
  e4e969b

• self-review cleanup

  david-crespo

  committed
  80cb5d0

Commits on Dec 14, 2023

• couldn't help it, had to fix the silo-scoped pools endpoints

  david-crespo

  committed
  bf29052

• make authz checks slightly more consistent, get rid of some assoc/dissoc language

  david-crespo

  committed
  32fcbc4

• PUT link 404s instead of 500 when the link doesn't exist

  david-crespo

  committed
  dc9de62

• clarify and clean up migrations, remove a couple of TODOs

  david-crespo

  committed
  ee0f363

• unlink takes authz_silo and authz_pool directly and does better auth check

  david-crespo

  committed
  3830c2a

• simplify and clarify migrations by using a subquery

  david-crespo

  committed
  06fcc99

Commits on Jan 3, 2024

• move migration up

  david-crespo

  committed
  e02a0e6

• Merge branch 'main' into ip-pools-rework (with conflicts)

  david-crespo

  committed
  ba1eb0e

• resolve conflicts

  david-crespo

  committed
  ea4cbfa

Commits on Jan 4, 2024

• add ip pool resource type to list of allowed enum names

  david-crespo

  committed
  8aa01b9

Commits on Jan 5, 2024

• clean up merge leftovers and TODOs that are becoming issues

  david-crespo

  committed
  584cb14

• move migrations up one

  david-crespo

  committed
  4976404

• Merge branch 'main' into ip-pools-rework

  david-crespo

  committed
  16cbd29