Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace-hack] record exact versions #4171

Merged

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Oct 2, 2023

Exact versions work better with dependabot.

With the configuration of dependabot we're running, consider what happens if a dependency (e.g. anyhow) that's in the workspace-hack (anyhow = { version = "1" }) gets updated. In that case, dependabot will add a patch version number (anyhow = { version = "1.0.75" }) to the workspace-hack, and then hakari will fail because it'll want to update it back to anyhow = { version = "1" }.

This change makes that not an issue -- hakari will expect, and want, the version number to be written out as anyhow = { version = "1.0.75" }.

Note that Dependabot isn't long for this world -- with #4166 we'll switch to Renovate, which (among other advantages) obviates this issue. However, we'll probably still want exact versions for uniformity with the rest of the workspace.

Created using spr 1.3.4
@sunshowers sunshowers enabled auto-merge (squash) October 2, 2023 16:51
@davepacheco
Copy link
Collaborator

@sunshowers would you mind summarizing any notes about why this matters? I'm thinking from the context of someone in the future wondering why we made this change, what would break if we wanted to undo it for some other reason, etc. I'm just afraid it won't be the last time we're debugging a dependabot failure.

@sunshowers
Copy link
Contributor Author

@davepacheco -- done, added to summary. Was in a bit of a rush this morning.

@davepacheco
Copy link
Collaborator

Thanks for that!

@sunshowers sunshowers merged commit e9210fc into main Oct 2, 2023
@sunshowers sunshowers deleted the sunshowers/spr/workspace-hack-record-exact-versions branch October 2, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants