[workspace-hack] record exact versions #4171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact versions work better with dependabot.
With the configuration of dependabot we're running, consider what happens if a dependency (e.g.
anyhow
) that's in the workspace-hack (anyhow = { version = "1" }
) gets updated. In that case, dependabot will add a patch version number (anyhow = { version = "1.0.75" }
) to the workspace-hack, and then hakari will fail because it'll want to update it back toanyhow = { version = "1" }
.This change makes that not an issue -- hakari will expect, and want, the version number to be written out as
anyhow = { version = "1.0.75" }
.Note that Dependabot isn't long for this world -- with #4166 we'll switch to Renovate, which (among other advantages) obviates this issue. However, we'll probably still want exact versions for uniformity with the rest of the workspace.