[update-engine] a few improvements to event buffers #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
sunshowers
force-pushed
the
sunshowers/spr/update-engine-a-few-improvements-to-event-buffers
branch
from
e4b53b7 to
aaa8c55
Compare
andrewjstone
approved these changes
Oct 11, 2023
| @@ -744,47 +784,83 @@ impl<'buf, S: StepSpec> EventBufferSteps<'buf, S> { | |||
| pub struct EventBufferStepData<S: StepSpec> { | |||
| step_info: StepInfo<NestedSpec>, | |||
| sort_key: StepSortKey, | |||
| // XXX: nest_level and total_steps are common to each execution, but are | |||
There was a problem hiding this comment.
I think ideally I would tie them together if they always exist together and get mutated together, but I wouldn't hold the PR for that.
There was a problem hiding this comment.
They always exist together but are immutable properties.
Co-authored-by: Andrew J. Stone <[email protected]>
Created using spr 1.3.4 [skip ci]
sunshowers
force-pushed
the
sunshowers/spr/update-engine-a-few-improvements-to-event-buffers
branch
from
d8312dd to
9ce8012
Compare
sunshowers
changed the base branch from
sunshowers/spr/main.update-engine-a-few-improvements-to-event-buffers
to
main
sunshowers
deleted the
sunshowers/spr/update-engine-a-few-improvements-to-event-buffers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated -- we're going to use this in the line-based displayer.
Depends on #4163.