Fix path checks for archived log files #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnaecker
commented
Sep 28, 2023
bnaecker
commented
- Fixes Path check for archived zone bundle log files is not correct #4160.
- Checks for archived log files were wrong. This used the SMF FMRI, rather than the derived log filename, which translates slashes into dashes. This separates checks for Oxide-managed FMRIs and the log files for those.
- Use the log file check when looking for archived files.
- Add tests for both checks and the method for finding archived log files for a service.
bnaecker
force-pushed
the
fix-archived-log-file-path-check
branch
from
746c3d7 to
6b7611f
Compare
- Fixes #4160. - Checks for archived log files were wrong. This used the SMF FMRI, rather than the derived log filename, which translates slashes into dashes. This separates checks for Oxide-managed FMRIs and the log files for those. - Use the _log file_ check when looking for archived files. - Add tests for both checks and the method for finding archived log files for a service.
bnaecker
force-pushed
the
fix-archived-log-file-path-check
branch
from
6b7611f to
d647557
Compare
jmpesp
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.