Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate omicron-dev, omdb, and xtask into "dev-tools" directory #4129

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

davepacheco
Copy link
Collaborator

In the spirit of #3350. Prior to this, we had:

  • omdb package at the top level for the omdb program
  • dev-tools package at the top level that only contained the omicron-dev program.
  • xtask package at the top level that only contains the xtask program.

The intent of dev-tools was to be a package that we could put other binaries in besides omicron-dev. But when I started putting omdb into it, I realized it needed a pretty different set of dependencies and that there was no reason to put them in the same package. So after this change:

  • "dev-tools" is a directory at the top level, not a Rust package
  • the omdb, omicron-dev, and xtask Rust packages are now inside "dev-tools"

@davepacheco davepacheco enabled auto-merge (squash) September 21, 2023 19:16
@davepacheco davepacheco merged commit 46ffb37 into main Sep 21, 2023
21 of 22 checks passed
@davepacheco davepacheco deleted the dap/dev-tools branch September 21, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants