Move instance networking functions into their own module #4123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nexus/src/app/instance.rs
andsled.rs
implement several networking-related functions that are less directly concerned with instance or sled management than their sibling routines. Tidy things up a bit by creating aninstance_network
module and moving instance V2P and NAT management functions there. Also, move instance NAT entry deletion logic into its own function that's called from the instance delete saga instead of implementing it inline in that saga.These changes aim to reduce clutter in
instance.rs
and to move NAT entry deletion to a function that can be reused by subsequent changes to the way Nexus handles instance stop.Except for some minor edits to error handling in
instance_delete_dpd_config
(needed because this function no longer returns asteno::ActionError
), this PR only rearranges existing code and has no functional changes.