add smoke test for omdb
#4101
Merged
add smoke test for omdb
#4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
commented
Sep 16, 2023
| @@ -34,17 +34,17 @@ pub struct NexusArgs { | |||
| #[derive(Debug, Subcommand)] | |||
| enum NexusCommands { | |||
| /// print information about background tasks | |||
| BackgroundTask(BackgroundTaskArgs), | |||
| BackgroundTasks(BackgroundTasksArgs), | |||
There was a problem hiding this comment.
I just noticed the lack of plural was inconsistent with other subcommands.
jordanhendricks
approved these changes
Sep 18, 2023
This reverts commit af97c37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple expectorate-based test to verify output of
omdb. The goal here is to help people iterate on omdb without unknowingly breaking basic functionality. At this point, I feel we should feel totally comfortable changing the output. The point of the test is to be able to tell when you're doing it (and how). The test is far from exhaustive.One annoying thing is that the information
omdbprints necessarily varies between test runs (e.g., timestamps, internal service TCP port numbers). So there's a process here for redacting that stuff so that the expectorate output looks the same.