Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform rack network initialization earlier in rack setup #3276

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Perform rack network initialization earlier in rack setup #3276

merged 3 commits into from
Jun 2, 2023

Conversation

internet-diglett
Copy link
Contributor

@internet-diglett internet-diglett commented Jun 1, 2023 •
edited
Loading

Perform rack network initialization before NTP sync is required, since NTP needs to communicate with the outside world.

  • This splits the network configuration logic from the record creation logic, since CRDB is not online when the network is created (NTP must be sync'd before starting CRDB )
  • Logic added for advertising boundary services loopback address via ddm
  • Added PortSpeed setting to RackNetworkConfig

Closes #3271

Awaiting https://github.com/oxidecomputer/dendrite/pull/356

@internet-diglett internet-diglett marked this pull request as ready for review June 1, 2023 23:57
rcgoodfellow
rcgoodfellow reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@rcgoodfellow rcgoodfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Levon - thanks for the quick turn on this. A few comments.

nexus/src/app/rack.rs Outdated Show resolved Hide resolved
sled-agent/src/rack_setup/service.rs Outdated Show resolved Hide resolved
sled-agent/src/rack_setup/service.rs Show resolved Hide resolved
sled-agent/src/rack_setup/service.rs Outdated Show resolved Hide resolved
sled-agent/src/rack_setup/service.rs Outdated Show resolved Hide resolved
sled-agent/src/rack_setup/service.rs Show resolved Hide resolved
@internet-diglett internet-diglett merged commit a0829d8 into main Jun 2, 2023
@internet-diglett internet-diglett deleted the initialize-network-before-ntp branch June 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcgoodfellow rcgoodfellow rcgoodfellow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advertise boundary services tunnel endpoint address via ddm
2 participants
@internet-diglett @rcgoodfellow