Skip to content

Commit

Permalink
install_builder_prerequisites failed after recent Helios upgrade
Browse files Browse the repository at this point in the history
Instead of always trying to install {gcc,g++}-runtime version 13,
update them to the latest if they are not new enough to support
the pre-compiled illumos clickhouse binaries.

Fixes #7292
  • Loading branch information
citrus-it committed Dec 20, 2024
1 parent 460f038 commit c46392c
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions tools/install_builder_prerequisites.sh
Original file line number Diff line number Diff line change
Expand Up @@ -138,22 +138,30 @@ function install_packages {
fi
elif [[ "${HOST_OS}" == "SunOS" ]]; then
CLANGVER=15
RTVER=13
PGVER=13
packages=(
"pkg:/package/pkg"
"build-essential"
"library/postgresql-$PGVER"
"pkg-config"
"library/libxmlsec1"
"system/library/gcc-runtime@$RTVER"
"system/library/g++-runtime@$RTVER"
# "bindgen leverages libclang to preprocess, parse, and type check C and C++ header files."
"pkg:/ooce/developer/clang-$CLANGVER"
"system/library/gcc-runtime"
"system/library/g++-runtime"
)

# The clickhouse binary depends on the {gcc,g++}-runtime packages being
# at least version 13. If we are on a version below that, update to the
# latest.
RTVER=13
for p in system/library/gcc-runtime system/library/g++-runtime; do
# buildmat runners do not yet have a new enough `pkg` for -o
#v=$(pkg list -Ho release $p)
v=$(pkg list -H -F tsv $p | awk '{split($2, a, "-"); print a[1]}')
((v < RTVER)) && packages+=($p@latest)
done

# Install/update the set of packages.
# Explicitly manage the return code using "rc" to observe the result of this
# command without exiting the script entirely (due to bash's "errexit").
Expand Down

0 comments on commit c46392c

Please sign in to comment.