oh, right: you have to actually remove the Result

i nearly pulled a @bnaecker with this one!

gateway/src/lib.rs

@@ -155,10 +155,7 @@ impl Server {
         let all_servers_shutdown = FuturesUnordered::new();
 
         let metrics =
-            metrics::Metrics::new(&log, &args, config.metrics, apictx.clone())
-                .map_err(|err| {
-                    format!("failed to initialize metrics subsystem: {err}")
-                })?;
+            metrics::Metrics::new(&log, &args, config.metrics, apictx.clone());
 
         for addr in args.addresses {
             start_dropshot_server(

gateway/src/metrics.rs

@@ -182,7 +182,7 @@ impl Metrics {
         args: &MgsArguments,
         cfg: MetricsConfig,
         apictx: Arc<ServerContext>,
-    ) -> anyhow::Result<Self> {
+    ) -> Self {
         let &MgsArguments { id, rack_id, ref addresses } = args;
         // Create a channel for the SP poller tasks to send samples to the
         // Oximeter producer endpoint.
@@ -241,7 +241,7 @@ impl Metrics {
                 ServerManager { log, addrs: addrs_rx, registry }.run(cfg),
             )
         };
-        Ok(Self { addrs_tx, rack_id_tx, server })
+        Self { addrs_tx, rack_id_tx, server }
     }
 
     pub fn set_rack_id(&mut self, rack_id: Uuid) {