Skip to content

Commit

Permalink
comment cleanup from PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
jgallagher committed Feb 8, 2024
1 parent d332154 commit 7ae7461
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 2 additions & 3 deletions nexus/deployment/src/planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,8 @@ impl<'a> Planner<'a> {
// keys, expecting to stop on the first iteration, with the only
// exception being when we've removed all the sleds from a bin.
for (&num_nexus, sleds) in sleds_by_num_nexus.iter_mut() {
// TODO choose more smartly than effectively ordering by
// sled_id? See
// https://github.com/oxidecomputer/omicron/pull/4959#discussion_r1476795735.
// `sleds` contains all sleds with the minimum number of Nexus
// zones. Pick one arbitrarily but deterministically.
let Some(sled_id) = sleds.pop() else {
// We already drained this bin; move on.
continue;
Expand Down
4 changes: 0 additions & 4 deletions nexus/types/src/deployment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ pub struct Policy {
pub service_ip_pool_ranges: Vec<IpRange>,

/// desired total number of deployed Nexus zones
// This number probably doesn't make sense alone once we get to a world
// where we're deploying multiple _versions_ of Nexus and need to ensure a
// minimum number in service at any given time, but for now all we know how
// to do is deploy a fixed number of all-the-same-version.
pub target_nexus_zone_count: usize,
}

Expand Down

0 comments on commit 7ae7461

Please sign in to comment.