Skip to content

Commit

Permalink
clarify why the phantom disk background task is required
Browse files Browse the repository at this point in the history
  • Loading branch information
jmpesp committed Dec 1, 2023
1 parent 615679a commit 6e0827c
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions nexus/src/app/background/phantom_disks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@
//! unwound: before a fix for customer-support#58, this would leave disks
//! deleted but would also leave a `virtual_provisioning_resource` record for
//! that disk. There would be no way to re-trigger the disk delete saga as the
//! disk was deleted, so the project that disk was in could not be deleted.
//! disk was deleted, so the project that disk was in could not be deleted
//! because associated virtual provisioning resources were still being consumed.
//!
//! This background task detects that case and sets the disk to "faulted". The
//! fix for customer-support#58 is similar: it changes the disk delete saga's
//! unwind to also un-delete the disk and set it to faulted. This enables it to
//! be deleted again.
//! The fix for customer-support#58 changes the disk delete saga's unwind to
//! also un-delete the disk and set it to faulted. This enables it to be deleted
//! again. Correcting the disk delete saga's unwind means that phantom disks
//! will not be created in the future when the disk delete saga unwinds, but
//! this background task is required to apply the same fix for disks that are
//! already in this phantom state.
use super::common::BackgroundTask;
use futures::future::BoxFuture;
Expand Down

0 comments on commit 6e0827c

Please sign in to comment.